Skip to content

Update sbt-scalajs, scalajs-compiler, ... to 1.8.0 #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update sbt-scalajs, scalajs-compiler, ... to 1.8.0 #433

wants to merge 1 commit into from

Conversation

scala-steward
Copy link
Contributor

Updates

from 1.7.1 to 1.8.0.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Ignore future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-js" } ]

labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

@xuwei-k
Copy link
Contributor

xuwei-k commented Dec 14, 2021

https://github.com/scala/scala-parser-combinators/runs/4490784242?check_suite_focus=true#step:5:37

[error] Incompatibilities with dependencies of scala-parser-combinators:2.1.0
[error] org.scala-js:scalajs-library_2.13: incompatible version change from 1.7.0 to 1.8.0

[error] Dependencies of module scala-parser-combinators:2.1.0+13-4938eb6e-SNAPSHOT break the intended compatibility guarantees 'Compatibility.BinaryAndSourceCompatible' (see messages above). You have to relax your compatibility intention by changing the value of versionPolicyIntention.
[error] (parserCombinatorsJS / versionPolicyReportDependencyIssues) Dependencies of module scala-parser-combinators:2.1.0+13-4938eb6e-SNAPSHOT break the intended compatibility guarantees 'Compatibility.BinaryAndSourceCompatible' (see messages above). You have to relax your compatibility intention by changing the value of versionPolicyIntention.

@xuwei-k xuwei-k requested a review from sjrd January 23, 2022 03:32
@sjrd
Copy link
Member

sjrd commented Jan 24, 2022

Upgrading to a new minor version of a dependency requires a minor version bump. That's because you'll force the newer dependency on your users, and they might also be directly referring to APIs in it. So the CI here is correct.

@scala-steward
Copy link
Contributor Author

Superseded by #448.

@scala-steward scala-steward deleted the update/sbt-scalajs-1.8.0 branch February 15, 2022 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd Awaiting requested review from sjrd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scala-steward @xuwei-k @sjrd